[fix][broker] Fix NPE after publishing a tombstone to the service unit channel #22859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t channel ### Motivation NPE will happen in `UnloadManager#handleEvent` after apache#22743. It's because the `Init` state is always associated with a null `ServiceUnitStateData`. ``` java.lang.NullPointerException: Cannot invoke "org.apache.pulsar.broker.loadbalance.extensions.channel.ServiceUnitStateData.force()" because "data" is null at org.apache.pulsar.broker.loadbalance.extensions.manager.UnloadManager.handleEvent(UnloadManager.java:204) ~[classes/:?] at org.apache.pulsar.broker.loadbalance.extensions.channel.StateChangeListeners.lambda$notify$3(StateChangeListeners.java:74) ~[classes/:?] at java.base/java.util.concurrent.CopyOnWriteArrayList.forEach(CopyOnWriteArrayList.java:807) ~[?:?] at org.apache.pulsar.broker.loadbalance.extensions.channel.StateChangeListeners.notify(StateChangeListeners.java:72) ~[classes/:?] at org.apache.pulsar.broker.loadbalance.extensions.channel.ServiceUnitStateChannelImpl.handleInitEvent(ServiceUnitStateChannelImpl.java:902) ~[classes/:?] at org.apache.pulsar.broker.loadbalance.extensions.channel.ServiceUnitStateChannelImpl.handle(ServiceUnitStateChannelImpl.java:715) ~[classes/:?] ``` ### Modifications In `UnloadManager#handleEvent`, assume `data` is null and call `complete` directly. Fix `UnloadManagerTest`, which passes a non-null `ServiceUnitStateData` and `Init` to `handleEvent`.
BewareMyPower
requested review from
lhotari,
Technoboy-,
codelipenghui,
RobertIndie,
Demogorgon314 and
heesung-sn
dao-jun
approved these changes
Jun 6, 2024
heesung-sn
approved these changes
Jun 6, 2024
|
Thank you for catching this. |
|
@BewareMyPower |
|
The checkstyle issue is fixed now. |
Demogorgon314
approved these changes
Jun 7, 2024
heesung-sn
pushed a commit
to heesung-sn/pulsar
that referenced
this pull request
Jun 26, 2024
…t channel (apache#22859) (cherry picked from commit 9326a08)
heesung-sn
pushed a commit
to heesung-sn/pulsar
that referenced
this pull request
Jun 26, 2024
…t channel (apache#22859) (cherry picked from commit 9326a08)
heesung-sn
pushed a commit
to heesung-sn/pulsar
that referenced
this pull request
Jun 26, 2024
…t channel (apache#22859) (cherry picked from commit 9326a08) (cherry picked from commit 6eac7e5)
heesung-sn
pushed a commit
to heesung-sn/pulsar
that referenced
this pull request
Jun 26, 2024
…t channel (apache#22859) (cherry picked from commit 9326a08)
heesung-sn
pushed a commit
to heesung-sn/pulsar
that referenced
this pull request
Jun 26, 2024
…t channel (apache#22859) (cherry picked from commit 9326a08)
heesung-sn
pushed a commit
to heesung-sn/pulsar
that referenced
this pull request
Jun 26, 2024
…t channel (apache#22859) (cherry picked from commit 9326a08)
heesung-sn
pushed a commit
to heesung-sn/pulsar
that referenced
this pull request
Jun 26, 2024
…t channel (apache#22859) (cherry picked from commit 9326a08) (cherry picked from commit 6eac7e5)
heesung-sn
pushed a commit
to heesung-sn/pulsar
that referenced
this pull request
Jun 27, 2024
…t channel (apache#22859) (cherry picked from commit 9326a08) (cherry picked from commit 6eac7e5)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 27, 2024
…t channel (apache#22859) (cherry picked from commit 9326a08) (cherry picked from commit 6eac7e5) (cherry picked from commit 9ffbffc)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 1, 2024
…t channel (apache#22859) (cherry picked from commit 9326a08) (cherry picked from commit 6eac7e5) (cherry picked from commit 9ffbffc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
NPE will happen in
UnloadManager#handleEventafter #22743. It's because theInitstate is always associated with a nullServiceUnitStateData.Modifications
In
UnloadManager#handleEvent, assumedatais null and callcompletedirectly. FixUnloadManagerTest, which passes a non-nullServiceUnitStateDataandInittohandleEvent.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: